Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Low Level REST Client should emphasize ContentType #22940

Merged

Conversation

pickypg
Copy link
Member

@pickypg pickypg commented Feb 2, 2017

This adds a callout to note that the Low Level REST Client example sets the ContentType explicitly and that users should do the same (ContentType is required by all of the HttpEntity's that I am aware of, but it's not required to be set properly).

I will drop the Future releases of Elasticsearch will require this to be set properly. sentence from the master branch in a follow-up commit.

Relates to #19388

This adds a callout to note that the Low Level REST Client example sets
the `ContentType` explicitly and that users should do the same.
@pickypg pickypg added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >docs General docs changes review v5.0.3 v5.1.3 v5.2.1 v5.3.0 v6.0.0-alpha1 labels Feb 2, 2017
@pickypg pickypg requested a review from javanna February 2, 2017 19:04
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pickypg LGTM

@pickypg pickypg merged commit dabc51f into elastic:master Feb 4, 2017
@pickypg pickypg deleted the docs/important-to-set-content-type-rest branch February 4, 2017 00:49
pickypg added a commit that referenced this pull request Feb 4, 2017
This adds a callout to note that the Low Level REST Client example sets the `ContentType` explicitly and that users should do the same.
pickypg added a commit that referenced this pull request Feb 4, 2017
This adds a callout to note that the Low Level REST Client example sets the `ContentType` explicitly and that users should do the same.
pickypg added a commit that referenced this pull request Feb 4, 2017
This adds a callout to note that the Low Level REST Client example sets the `ContentType` explicitly and that users should do the same.
pickypg added a commit that referenced this pull request Feb 4, 2017
This adds a callout to note that the Low Level REST Client example sets the `ContentType` explicitly and that users should do the same.
@pickypg
Copy link
Member Author

pickypg commented Feb 4, 2017

5.x/5.3: 1ee80d4
5.2: c955b18
5.1: 493ab4f
5.0: b21ee52

@pickypg
Copy link
Member Author

pickypg commented Feb 4, 2017

master/6.0: d2428b1 (removal of last sentence)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >docs General docs changes v5.0.3 v5.1.3 v5.2.1 v5.3.0 v6.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants