Replace IndicesQueriesRegistry #22289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjernst or @imotov or @javanna or @martijnvg want to have a look? I'm not picky who looks.... |
nik9000
commented
Dec 21, 2016
| ParseFieldMatcher parseFieldMatcher) { | ||
| QueryParseContext context = new QueryParseContext(indicesQueriesRegistry, requestParser, parseFieldMatcher); | ||
| public static QueryBuilder getQueryContent(XContentParser requestParser, ParseFieldMatcher parseFieldMatcher) { | ||
| // NOCOMMIT it is very close to time to remove this |
There was a problem hiding this comment.
But not yet time, I think. This PR is big enough as is.
javanna
changed the title
Replace it with `XContentParser#namedObject`.
nik9000
force-pushed
the
named_xcontent_queries
branch
from
d1e7b20 to
c135f66
Compare
|
Thanks for reviewing @martijnvg! One more parser registry down and one less thing bound in guice. Hurray! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 21, 2016
* master: Simplify Unicast Zen Ping (elastic#22277) Replace IndicesQueriesRegistry (elastic#22289) Fixed document mistake and fit for 5.1.1 API [TEST] improve error message in ESTestCase#assertWarnings [TEST] remove deleted test classes from checkstyle suppressions [TEST] make ESSingleNodeTestCase tests repeatable (elastic#22283) Link for setting page in elasticsearch.yml is outdated Factor out sort values from InternalSearchHit (elastic#22080) Add ID for percolate query to Java API docs x_refresh.yaml tests should use unique index names and doc ids to ease debugging IndicesStoreIntegrationIT should not use start recovery sending as an indication that the recovery started Added base class for testing aggregators and some initial tests for `terms`, `top_hits` and `min` aggregations. Add link to foreach processor to ingest-attachment.asciidoc
nik9000
added a commit
that referenced
this pull request
Dec 22, 2016
* Switch query parsing to namedObject * Remove IndicesQueriesRegistry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
IndicesQueriesRegistrywithXContentParser#namedObject.This is the first of the real payoff for #22003, one less thing to pass around the entire application. Now the parsers it contained are wrapped in the
XContentParser.