-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IndexTemplateAlreadyExistsException
and IndexShardAlreadyExistsException
#21539
Conversation
…istsException` Both exception can be replaced with java built-in exception, IAE and ISE respectively. This should be backported partially to 5.x which the transport layer code should be preserved. Relates to elastic#21494
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one minor comment. LGTM
@@ -553,7 +551,7 @@ public String toString() { | |||
org.elasticsearch.common.io.stream.NotSerializableExceptionWrapper::new, 62), | |||
ALIAS_FILTER_PARSING_EXCEPTION(org.elasticsearch.indices.AliasFilterParsingException.class, | |||
org.elasticsearch.indices.AliasFilterParsingException::new, 63), | |||
// 64 was DeleteByQueryFailedEngineException, which was removed in 3.0 | |||
// 64 was DeleteByQueryFailedEngineException, which was removed in 6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 5.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah :D I will fix
* master: (82 commits) Remove `IndexTemplateAlreadyExistsException` and `IndexShardAlreadyExistsException` (elastic#21539) Fix line length in TCPTransportTests Check valid cluster service state transitions (elastic#21538) [TEST] Add test to ensure `transport.tcp.compress` works remove forbidden API Enable 5.x to 6.x BWC tests Set LoggedExec back Rebasing master Add Vagrant Gradle plugin [docs] clients need to add jackson-databind (elastic#21527) Update significantterms-aggregation.asciidoc Upgrade to lucene-6.3.0. (elastic#21464) Hack around cluster service and logging race Do not prematurely shutdown Log4j Support decimal constants with trailing [dD] in painless (elastic#21412) In painless suggest a long constant if int won't do (elastic#21415) Account for different paths for sysctl utilities [TEST] testRebalancePossible() may not have an assigned node id Tests: Disable merge in SearchCancellationTests Tests: clean search scroll at the end of SearchCancellationIT ...
I also back-ported this to 5.x in d80562d |
Both exception can be replaced with java built-in exception, IAE and ISE respectively.
This should be backported partially to 5.x which the transport layer code should be preserved.
Relates to #21494