Tests: Remove a couple test uses of onModule #21414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
>test
There were still a couple test use cases and examples that were using onModule. This change cleans those cases up.
rjernst
force-pushed
the
less_on_module
branch
from
3fc15ab to
d442dec
Compare
nik9000
approved these changes
Nov 8, 2016
rjernst
added a commit
that referenced
this pull request
Nov 8, 2016
There were still a couple test use cases and examples that were using onModule. This change cleans those cases up.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Nov 9, 2016
This reverts commit 3748371.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Nov 9, 2016
This reverts commit b326f0b.
|
Heads up I just reverted this change on both master and 5.x as it was causing consistent build failures: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+periodic/589/console . |
rjernst
added a commit
that referenced
this pull request
Nov 11, 2016
This change was reverted after it caused random test failures. This was due to a copy/paste error in the original PR which caused the mock version of ClusterInfoService to be used whenever the mock *ZenPing* was used, and the real ClusterInfoService to be used when MockZenPing was not used.
rjernst
added a commit
that referenced
this pull request
Nov 11, 2016
This change was reverted after it caused random test failures. This was due to a copy/paste error in the original PR which caused the mock version of ClusterInfoService to be used whenever the mock *ZenPing* was used, and the real ClusterInfoService to be used when MockZenPing was not used.
|
I recommitted this, it was a silly copy/paste error in the logic of when to use the mock vs real ClusterInfoService, which caused random havoc. |
jasontedor
added a commit
that referenced
this pull request
Nov 11, 2016
* master: ShardActiveResponseHandler shouldn't hold to an entire cluster state Ensures cleanup of temporary index-* generational blobs during snapshotting (#21469) Remove (again) test uses of onModule (#21414) [TEST] Add assertBusy when checking for pending operation counter after tests Revert "Add trace logging when aquiring and releasing operation locks for replication requests" Allows multiple patterns to be specified for index templates (#21009) [TEST] fixes rebalance single shard check as it isn't guaranteed that a rebalance makes sense and the method only tests if rebalance is allowed Document _reindex with random_score
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were still a couple test use cases and examples that were using
onModule. This change cleans those cases up.