Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter client/server VM options from jvm.options #18473

Merged
merged 1 commit into from
May 20, 2016
Merged

Filter client/server VM options from jvm.options #18473

merged 1 commit into from
May 20, 2016

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented May 19, 2016

The default jvm.options file ships with the -server flag to force the
server VM on systems where the server VM is not the default. However,
the method of starting the JVM via the Windows service does not support
the command-line flags for selecting the VM because it starts from a
DLL that is specific to the server or client VM. Thus, we need to
filter these options from the jvm.options configuration file when
installing the Windows service.

@jasontedor jasontedor added >bug review :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v5.0.0-alpha3 labels May 19, 2016
The default jvm.options file ships with the -server flag to force the
server VM on systems where the server VM is not the default. However,
the method of starting the JVM via the Windows service does not support
the command-line flags for selecting the VM because it starts from a
DLL that is specific to the server or client VM. Thus, we need to
filter these options from the jvm.options configuration file when
installing the Windows service.
@dakrone
Copy link
Member

dakrone commented May 20, 2016

LGTM really wish we had a test for this (not this PRs fault)

@jasontedor
Copy link
Member Author

jasontedor commented May 20, 2016

LGTM

Thanks for reviewing.

really wish we had a test for this (not this PRs fault)

Agree. Issue #18475 was opened for this reason. 😄

@jasontedor jasontedor merged commit 452faa2 into elastic:master May 20, 2016
@jasontedor jasontedor deleted the windows-service-client-server-vm branch May 20, 2016 19:25
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v5.0.0-alpha3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants