Fix issue with tombstones matching active indices in cluster state #18058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeyad
force-pushed
the
bug/cannot-delete-index
branch
from
3c2e8ed to
189ef0e
Compare
|
@jasontedor Perhaps you'd like to review? The test I wrote passes even before making the change in |
|
LGTM. Thanks @abeyad. |
name and uuid because the cluster state may contain an active index of the same name (but different uuid). Closes elastic#18058 Closes elastic#18054
abeyad
force-pushed
the
bug/cannot-delete-index
branch
from
189ef0e to
4511382
Compare
|
@jasontedor Changed the test to go in |
Much better. 😄 LGTM. |
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if an index tombstone can be applied, use both the index name and uuid because the cluster state may contain an active index of the same name (but different uuid).
Closes #18054