Adds ignore_unmapped option to nested and P/C queries
#17748
Conversation
| fail("expected has_children query on unmapped field to fail when ignore_unmapped is false"); | ||
| } catch (QueryShardException e) { | ||
| assertThat(e.getMessage(), containsString("[" + HasChildQueryBuilder.NAME + "] no mapping found for type [unmapped]")); | ||
| } |
There was a problem hiding this comment.
Can you use expectThrows instead? I think we should use it rather than this try:fail/catch:check_msg pattern for new code.
|
A minor concern I have is that |
|
maybe we should name this setting |
|
I'm ok with changing it to |
|
|
|
Docs LGTM |
| @@ -464,12 +502,12 @@ protected boolean doEquals(HasChildQueryBuilder that) { | |||
| && Objects.equals(scoreMode, that.scoreMode) | |||
| && Objects.equals(minChildren, that.minChildren) | |||
| && Objects.equals(maxChildren, that.maxChildren) | |||
| && Objects.equals(innerHitBuilder, that.innerHitBuilder); | |||
| && Objects.equals(innerHitBuilder, that.innerHitBuilder) && Objects.equals(ignoreUnmapped, that.ignoreUnmapped); | |||
There was a problem hiding this comment.
let's put it on the next line to be consistent?
|
LGTM |
The change adds a new option to the `nested`, `has_parent`, `has_children` and `parent_id` queries: `ignore_unmapped`. If this option is set to false, the `toQuery` method on the QueryBuilder will throw an exception if the type/path specified in the query is unmapped. If the option is set to true, the `toQuery` method on the QueryBuilder will return a MatchNoDocsQuery. The default value is `false`so the queries work how they do today (throwing an exception on unmapped paths/types)
clintongormley
changed the title
ignore_unmapped option to nested and P/C queries
clintongormley
added
:Search/Search
The change adds a new option to the
nested,has_parent,has_childrenandparent_idqueries:ignore_unmapped. If this option is set to false, thetoQuerymethod on the QueryBuilder will throw an exception if the type/path specified in the query is unmapped. If the option is set to true, thetoQuerymethod on the QueryBuilder will return a MatchNoDocsQuery. The default value isfalseso the queries work how they do today (throwing an exception on unmapped paths/types)