Add setFactory permission to GceDiscoveryPlugin #16860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,7 @@ | |||
| import java.util.Collection; | |||
| import java.util.Collections; | |||
| import java.util.List; | |||
| import java.util.function.Function; | |||
This commit adds a missing permission and a simple test that ensures we discover other nodes via a mock http endpoint. Closes elastic#16485
|
Interesting. I like the idea of using an HTTP server to serve the mock responses. LGTM |
|
This looks ok to me. It is good to have some kind of test for GCE. I'm apprehensive about checking in the keyfile, but I guess it is just for a test... At another time, I am happy to look at moving this to a fixture, as well as generating the keyfile, but this PR at least gets us into a better state than we are now. |
|
+1 |
…e to the source repo
|
@rjernst @jasontedor I pushed a new commit generating the keystore from gradle |
|
Looks good, thanks! |
|
LGTM. |
s1monw
added a commit
that referenced
this pull request
Mar 1, 2016
Add setFactory permission to GceDiscoveryPlugin This commit adds a missing permission and a simple test that ensures we discover other nodes via a mock http endpoint. Closes #16485
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Mar 1, 2016
This commit adds a missing permission and a simple test that ensures we discover other nodes via a mock http endpoint. Backport of elastic#16860 Relates to elastic#16485
clintongormley
added
:Distributed Coordination/Discovery-Plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a missing permission and a simple test that
ensures we discover other nodes via a mock http endpoint.
Closes #16485
@rjernst I had to make this integ test a ordinary testcase since it runs against an internal cluster. I didn't explore the test fixture path yet since it also requires a test plugin etc. I wonder if we can make this one test run against the internal cluster while others runs against external clusters? I am not super happy with the test but it's a major step forward since it really tests the integration of this plugins while everything else isn't really testing it. It also would have caught the security issue though