Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check lenient_expand_open after aliases have been resolved #15882

Merged
merged 1 commit into from
Jan 11, 2016

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Jan 11, 2016

We fail today with ClusterBlockExceptions if an alias expands to a closed index
during search since we miss to check the index option down the road after we expanded
aliases.

Closes #13278

@javanna
Copy link
Member

javanna commented Jan 11, 2016

LGTM thanks a lot @s1monw

@@ -189,6 +189,7 @@ public IndexNameExpressionResolver(Settings settings) {
return concreteIndices.toArray(new String[concreteIndices.size()]);
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove added newline?

@martijnvg
Copy link
Member

LGTM. Thanks @s1monw for fixing this.

We fail today with ClusterBlockExceptions if an alias expands to a closed index
during search since we miss to check the index option down the road after we expanded
aliases.

Closes elastic#13278
s1monw added a commit that referenced this pull request Jan 11, 2016
Check lenient_expand_open after aliases have been resolved
@s1monw s1monw merged commit 55b0ece into elastic:master Jan 11, 2016
@s1monw s1monw deleted the issues/13278 branch January 11, 2016 12:31
@s1monw
Copy link
Contributor Author

s1monw commented Jan 11, 2016

pushed to all relevant branches...

@oferbar
Copy link

oferbar commented Jan 11, 2016

Hi, is this also fixed for 1.6 or just 2.x?
Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching multiple aliases using wildcard and ignore_unavailable=true throws index closed exception
5 participants