-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check lenient_expand_open after aliases have been resolved #15882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM thanks a lot @s1monw |
@@ -189,6 +189,7 @@ public IndexNameExpressionResolver(Settings settings) { | |||
return concreteIndices.toArray(new String[concreteIndices.size()]); | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove added newline?
LGTM. Thanks @s1monw for fixing this. |
We fail today with ClusterBlockExceptions if an alias expands to a closed index during search since we miss to check the index option down the road after we expanded aliases. Closes elastic#13278
s1monw
added a commit
that referenced
this pull request
Jan 11, 2016
Check lenient_expand_open after aliases have been resolved
pushed to all relevant branches... |
Hi, is this also fixed for 1.6 or just 2.x? |
This was referenced Jan 13, 2016
clintongormley
added
the
:Data Management/Indices APIs
APIs to create and manage indices and templates
label
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fail today with ClusterBlockExceptions if an alias expands to a closed index
during search since we miss to check the index option down the road after we expanded
aliases.
Closes #13278