Only allow rebalance operations to run if all shard store data is available #14652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilable This commit prevents running rebalance operations if the store allocator is still fetching async shard / store data to prevent pre-mature rebalance decisions which need to be reverted once shard store data is available. This is typically happening on rolling restarts which can make those restarts extremely painful. Closes elastic#14387
|
@bleskes can you take a quick look - it's the 1.7 backport |
| @@ -1251,7 +1251,7 @@ public void restartRandomNode(RestartCallback callback) throws Exception { | |||
| * Restarts a random data node in the cluster | |||
| */ | |||
| public void restartRandomDataNode() throws Exception { | |||
| restartRandomNode(EMPTY_CALLBACK); | |||
| restartRandomDataNode(EMPTY_CALLBACK); | |||
|
LGTM |
s1monw
added a commit
that referenced
this pull request
Nov 11, 2015
Only allow rebalance operations to run if all shard store data is available
lcawl
added
:Distributed Indexing/Distributed
clintongormley
added
:Distributed Coordination/Allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents running rebalance operations if the store allocator is
still fetching async shard / store data to prevent pre-mature rebalance decisions
which need to be reverted once shard store data is available. This is typically happening
on rolling restarts which can make those restarts extremely painful.
Closes #14387
this is the 1.7 backport of #14591