Plugin script to set proper plugin bin dir attributes #14088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
>enhancement
review
:Core/Infra/Plugins
| // add file execute permissions to existing perms, so execution will work. | ||
| filePermissions.add(PosixFilePermission.OWNER_EXECUTE); | ||
| filePermissions.add(PosixFilePermission.GROUP_EXECUTE); | ||
| filePermissions.add(PosixFilePermission.OTHERS_EXECUTE); |
There was a problem hiding this comment.
I think we wanted the default to be 750 right? If so then we shouldn't set OTHERS_EXECUTE
There was a problem hiding this comment.
I am not sure what we want to do. I think the original description of the issue doesn't necessarily makes sense for the bin directory. I thought that leaving what we already have shouldn't hurt, especially given that all other scripts that we have under bin (e.g. elasticsearch, plugin) have execute permissions for others too. The change is that we set user and group and we inherit other permissions form the parent dir instead of relying on what we already have on the file and forcing read access (what we did before). I am open to discussion of course :)
|
LGTM |
javanna
force-pushed
the
enhancement/plugin_bin_dir_permissions
branch
from
a3faa24 to
7df04e6
Compare
This commit makes sure that the plugin script looks at user, group and permissions of the elasticsearch bin dir and copies them over to the plugin bin subdirectory, whatever they are, so that they get properly setup depending on how elasticsearch was installed. We also make sure that execute permissions are added for files (we already did this before). Relates to elastic#11016 Closes elastic#14088
javanna
force-pushed
the
enhancement/plugin_bin_dir_permissions
branch
from
7df04e6 to
7368231
Compare
javanna
added a commit
that referenced
this pull request
Oct 14, 2015
This commit makes sure that the plugin script looks at user, group and permissions of the elasticsearch bin dir and copies them over to the plugin bin subdirectory, whatever they are, so that they get properly setup depending on how elasticsearch was installed. We also make sure that execute permissions are added for files (we already did this before). Relates to #11016 Closes #14088
javanna
added a commit
that referenced
this pull request
Oct 14, 2015
This commit makes sure that the plugin script looks at user, group and permissions of the elasticsearch bin dir and copies them over to the plugin bin subdirectory, whatever they are, so that they get properly setup depending on how elasticsearch was installed. We also make sure that execute permissions are added for files (we already did this before). Relates to #11016 Closes #14088
javanna
added a commit
that referenced
this pull request
Oct 14, 2015
This commit makes sure that the plugin script looks at user, group and permissions of the elasticsearch bin dir and copies them over to the plugin bin subdirectory, whatever they are, so that they get properly setup depending on how elasticsearch was installed. We also make sure that execute permissions are added for files (we already did this before). Relates to #11016 Closes #14088
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure that the plugin script looks at user, group and permissions of the elasticsearch bin dir and copies them over to the plugin bin subdirectory, whatever they are, so that they get properly setup depending on how elasticsearch was installed. We also make sure that execute permissions are added for files (we already did this before).
Relates to #11016