Never wrap searcher for internal engine operations #14071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no need to wrap the searcher for internal operations like version checks for indexing. In-fact this can even lead to crazy bugs if the wrapper filters documents that are updated etc. such that we end up with either duplicated docs if create is used or we update wrong version under certain conditions.
|
LGTM |
s1monw
added a commit
that referenced
this pull request
Oct 13, 2015
Never wrap searcher for internal engine operations
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Oct 13, 2015
Never wrap searcher for internal engine operations
s1monw
added a commit
that referenced
this pull request
Oct 13, 2015
Never wrap searcher for internal engine operations
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is no need to wrap the searcher for internal operations like version
checks for indexing. In-fact this can even lead to crazy bugs if the wrapper
filters documents that are updated etc. such that we end up with either duplicated docs
if create is used or we update wrong version under certain conditions.
Note: master doesn't have this particular problem since it wraps searchers on the
IndexShardlevel