Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Patch Shell class in hdfs to not execute (#119189) #119243

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[8.x] Patch Shell class in hdfs to not execute (#119189) #119243

merged 1 commit into from
Dec 23, 2024

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Dec 23, 2024

Backports the following commits to 8.x:

@rjernst
Patch Shell class in hdfs to not execute (elastic#119189)
072e000 
Shell utility in hdfs tries to execute a local script statically to
determine whether setsid is available. With the security manager this
doesn't work, but hdfs catches the SecurityException and assumes false.
With entitlements this doesn't work since hdfs does not know about our
NotEntitledException.

This commit reworks the patching of hdfs-client-api to use asm. It then
adds patching of hdfs' Shell class to replace the method that tries to
execute.
@rjernst rjernst added :Core/Infra/Core Core issues without another label :Delivery/Build Build or test infrastructure >refactoring auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team test-entitlements Trigger CI checks using security manager replacement labels Dec 23, 2024
@elasticsearchmachine elasticsearchmachine mentioned this pull request Dec 23, 2024
Merged
@elasticsearchmachine elasticsearchmachine merged commit adf66be into elastic:8.x Dec 23, 2024
15 checks passed
@rjernst rjernst deleted the backport/8.x/pr-119189 branch December 23, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Core Core issues without another label :Delivery/Build Build or test infrastructure >refactoring Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team test-entitlements Trigger CI checks using security manager replacement v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjernst @elasticsearchmachine