Conditionally mute synonyms config access test #119140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This synonyms test checks certain config files cannot be accessed. It relies on security manager, which is not enabled in JDK 24. Until the entitlement based replacement is available, this commit mutes the test. see elastic#119130
rjernst
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Dec 19, 2024
| [ | ||
| // this test relies on security manager, which doesn't exist in JDK 24. | ||
| // and entitlements don't yet replace the functionality. | ||
| // see https://github.com/elastic/elasticsearch/issues/119130 |
There was a problem hiding this comment.
Should we put "awaitsfix" in some for or another here in this comment so we can easily find this later?
There was a problem hiding this comment.
I don't know of an awaitsfix thing in gradle files, but I can certainly change the text to AWAITSFIX
There was a problem hiding this comment.
Yeah, that's all I meant. It just makes it easier to search for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This synonyms test checks certain config files cannot be accessed. It relies on security manager, which is not enabled in JDK 24. Until the entitlement based replacement is available, this commit mutes the test.
see #119130