-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release tests for SemanticMatchTestCase #119022
Conversation
Pinging @elastic/es-analytical-engine (Team:Analytics) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
I think you can use BeforeClass
to check assumptions in one place - I think I used that for other tests, although they were not ESRestTestCase
s
muted-tests.yml
Outdated
@@ -304,6 +304,9 @@ tests: | |||
- class: org.elasticsearch.cluster.coordination.NodeJoinExecutorTests | |||
method: testSuccess | |||
issue: https://github.com/elastic/elasticsearch/issues/119052 | |||
- class: org.elasticsearch.aggregations.bucket.SearchCancellationIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@original-brownbear as we discussed I am muting this test for main - it was already muted on 8.x.
💔 Backport failed
You can use sqren/backport to manually backport by running |
#119041
#119042
verified the fix by running:
same for single node tests.
example of a build scan failure: https://gradle-enterprise.elastic.co/s/dzxl5mrinyrqq
moving the assumption that checks the esql capability to the test methods fixes the issue.