Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release tests for SemanticMatchTestCase #119022

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

ioanatia
Copy link
Contributor

@ioanatia ioanatia commented Dec 18, 2024

#119041
#119042

verified the fix by running:

 ./gradlew ":x-pack:plugin:esql:qa:server:multi-node:javaRestTest" --tests "org.elasticsearch.xpack.esql.qa.multi_node.SemanticMatchIT.*" -Dtests.seed=9E0A907FC60B1BDE -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dlicense.key=x-pack/license-tools/src/test/resources/public.key

same for single node tests.

example of a build scan failure: https://gradle-enterprise.elastic.co/s/dzxl5mrinyrqq


Caused by: |  
-- | --
  | org.junit.AssumptionViolatedException: semantic text capability not available |  
  | at com.carrotsearch.randomizedtesting.RandomizedTest.assumeTrue(RandomizedTest.java:745) |  
  | at org.apache.lucene.tests.util.LuceneTestCase.assumeTrue(LuceneTestCase.java:860) |  
  | at org.elasticsearch.xpack.esql.qa.rest.SemanticMatchTestCase.wipeData(SemanticMatchTestCase.java:104) |  
  | at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) |  
  | at java.base/java.lang.reflect.Method.invoke(Method.java:580) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1763) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:1004) |  
  | ... 34 more

moving the assumption that checks the esql capability to the test methods fixes the issue.

@ioanatia ioanatia added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.18.0 labels Dec 18, 2024
@elasticsearchmachine elasticsearchmachine added v9.0.0 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Dec 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@ioanatia
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

I think you can use BeforeClass to check assumptions in one place - I think I used that for other tests, although they were not ESRestTestCases

muted-tests.yml Outdated
@@ -304,6 +304,9 @@ tests:
- class: org.elasticsearch.cluster.coordination.NodeJoinExecutorTests
method: testSuccess
issue: https://github.com/elastic/elasticsearch/issues/119052
- class: org.elasticsearch.aggregations.bucket.SearchCancellationIT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@original-brownbear as we discussed I am muting this test for main - it was already muted on 8.x.

@ioanatia ioanatia merged commit e504cec into elastic:main Dec 19, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants