Lower default mappings parsing compatibility to MINIMUM_READONLY_COMPATIBLE #119017
Conversation
…ATIBLE Legacy indices check what minimum compatibility version the type parser supports, for every field type found in the mappings. Only some of the basic fields are supported, otherwise a placeholder mapper is created in place of the real field. The minimum supported version is v5 for the supported field mappers. For all the others, we can lower that from MINIMUM_COMPATIBLE to MINIMUM_READONLY_COMPATIBLE. This commit also centralizes the creation of type parsers that declare support for archive indices, as they all declare the same version.
javanna
added
>refactoring
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
|
||
| public static TypeParser createTypeParserWithLegacySupport(BiFunction<String, MappingParserContext, Builder> builderFunction) { | ||
| return new TypeParser(builderFunction, MINIMUM_LEGACY_COMPATIBILITY_VERSION); | ||
| } |
There was a problem hiding this comment.
This makes the code a little easier to follow: there is one lower bound legacy compatibility constant, rather than one per mapper. After all the lower bound is always v5. It's also easier to follow what mappers provide legacy support, as they must now all call this method.
| } | ||
|
|
||
| public TypeParser( | ||
| BiFunction<String, MappingParserContext, Builder> builderFunction, | ||
| List<BiConsumer<String, MappingParserContext>> contextValidator | ||
| ) { | ||
| this(builderFunction, (n, c) -> contextValidator.forEach(v -> v.accept(n, c)), IndexVersions.MINIMUM_COMPATIBLE); | ||
| this(builderFunction, (n, c) -> contextValidator.forEach(v -> v.accept(n, c)), IndexVersions.MINIMUM_READONLY_COMPATIBLE); |
There was a problem hiding this comment.
Effectively, lowering the minimum compatible doesn't take any effect, because we were checking the lower bound only for legacy indices which provide their specific lower bound. The default minimum compatible version could have been null for what it mattered.
| } else { | ||
| assert parser == null || parser.supportsVersion(indexVersionCreated); |
There was a problem hiding this comment.
With this assertion, we are now checking the min compatible version for all indices, and making sure that things are consistent. That said, only legacy indices will ever check the version compatibility in prod code.
|
@cbuescher correct, I left some comments in the PR to clarify the goal and the effect they have. |
Legacy indices check what minimum compatibility version the type parser supports, for every field type found in the mappings. Only some of the basic fields are supported, otherwise a placeholder mapper is created in place of the real field.
The minimum supported version is v5 for the supported field mappers. For all the others, we can lower that from MINIMUM_COMPATIBLE to MINIMUM_READONLY_COMPATIBLE.
This commit also centralizes the creation of type parsers that declare support for archive indices, as they all declare the same version.