Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Add a LicenseAware interface for licensed Nodes #118931

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Dec 18, 2024

This adds a new interface that elements that require a proper license state can implement to enforce the license requirement. This can be now applied to any node or node property.

The check still happens in the Verifier, since the plan needs to be analysed first and the check still only happens if no other verification faults exist already.

Fixes #117405

This adds a new interface that elements that require a proper license
state can implement to enforce the license requirement.
@bpintea bpintea added >enhancement auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Dec 18, 2024
@bpintea bpintea requested a review from iverase December 18, 2024 09:25
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @bpintea, I've created a changelog YAML for you.

@bpintea
Copy link
Contributor Author

bpintea commented Dec 19, 2024

Thanks Ievgen, Ignacio!

@bpintea bpintea merged commit 5f293f3 into elastic:main Dec 19, 2024
16 checks passed
@bpintea bpintea deleted the enh/license_aware_iface branch December 19, 2024 15:02
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

bpintea added a commit to bpintea/elasticsearch that referenced this pull request Dec 19, 2024
This adds a new interface that elements that require a proper license state can implement to enforce the license requirement. This can be now applied to any node or node property.

The check still happens in the Verifier, since the plan needs to be analysed first and the check still only happens if no other verification faults exist already.

Fixes elastic#117405
elasticsearchmachine pushed a commit that referenced this pull request Dec 19, 2024
)

This adds a new interface that elements that require a proper license state can implement to enforce the license requirement. This can be now applied to any node or node property.

The check still happens in the Verifier, since the plan needs to be analysed first and the check still only happens if no other verification faults exist already.

Fixes #117405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESQL: Improve license checks
4 participants