Add min. read-only index version compatible to DiscoveryNode #118744
Conversation
tlrx
added
>non-issue
:Distributed Coordination/Allocation
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
| public void testDiscoveryNodeMinReadOnlyVersionSerialization() throws Exception { | ||
| var node = DiscoveryNodeUtils.create( | ||
| "_id", | ||
| new TransportAddress( |
There was a problem hiding this comment.
Why not just ESTestCase.buildNewFakeTransportAddress()?
There was a problem hiding this comment.
No special reason, thanks for catching this. I pushed d23319b
| IndexVersion minIndexVersion = IndexVersion.readVersion(in); | ||
| IndexVersion minReadOnlyIndexVersion; | ||
| if (in.getTransportVersion().onOrAfter(NODE_VERSION_INFORMATION_WITH_MIN_READ_ONLY_INDEX_VERSION)) { | ||
| minReadOnlyIndexVersion = IndexVersion.readVersion(in); |
There was a problem hiding this comment.
It is good, but perhaps you can confirm my thinking here. I originally worried a little about it persisting due to residing in cluster state such that it would depend on the master's version.
It should work though since we require a full upgrade to 8.18 before upgrading to 9.0 (at least in a rolling fashion). Hence on 8.18, any master here would then see a new 9.0 node, hence it would have the N-2 min-read-only-version.
All good I think, just overcomplicating it (I think).
There was a problem hiding this comment.
I think it is OK too, yet it is not an area I'm super confortable with.
My understanding is that a cluster on 8.17 with indices created in 7.x should reject join requests from 9.0 nodes since the node will only communicate a min. index compatible version on 8.
Once this PR is merged in main and backported to 8.18, a master on 8.18 will receive join requests from 9.0 nodes with both the N-1 and N-2 information but should still reject the node if 7.x indices exist in the cluster since 9.0 is not able to read andwrite such indices (I expect to change this soon for read-only searchable snapshot indices in #118785).
tlrx
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
…lastic#118744) In a short future we'd like to use this information in methods like IndexMetadataVerifier#checkSupportedVersion and NodeJoineExecutor to allow opening indices in N-2 versions as read-only indices on ES V9.
…118744) (#118884) * [8.x] Add min. read-only index version compatible to DiscoveryNode (#118744) In a short future we'd like to use this information in methods like IndexMetadataVerifier#checkSupportedVersion and NodeJoineExecutor to allow opening indices in N-2 versions as read-only indices on ES V9. * MINIMUM_READONLY_COMPATIBLE
…#118744) elastic#118443 added a new index version for indices that can be opened in read-only mode by Lucene. This change adds this information to the discovery node's VersionInformation and the transport serialization logic. In a short future we'd like to use this information in methods like IndexMetadataVerifier#checkSupportedVersion and NodeJoineExecutor to allow opening indices in N-2 versions as read-only indices on ES V9.
We prefer to remove this information from the API since they are not useful externally, impact the search shard API and may be removed later (which would be a breaking change). Follow-up elastic#118744
We prefer to remove this information from the API since they are not useful externally, impact the search shard API and may be removed later (which would be a breaking change). Follow-up #118744
We prefer to remove this information from the API since they are not useful externally, impact the search shard API and may be removed later (which would be a breaking change). Follow-up elastic#118744
#118443 added a new index version for indices that can be opened in read-only mode by Lucene. This change adds this information to the discovery node's
VersionInformationand the transport serialization logic.In a short future we'd like to use this information in methods like
IndexMetadataVerifier#checkSupportedVersionandNodeJoineExecutorto allow opening indices in N-2 versions as read-only indices on ES V9.