ESQL: allow DATE_PARSE to read the timezones #118603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpintea
added
>bug
auto-backport
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
Hi @bpintea, I've created a changelog YAML for you. |
luigidellaquila
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
LGTM, thanks @bpintea
I left just a couple of comments about tests.
| () -> new TestCaseSupplier.TestCase( | ||
| List.of( | ||
| new TestCaseSupplier.TypedData(new BytesRef("dd/MMM/yyyy:HH:mm:ss Z"), DataType.KEYWORD, "first"), | ||
| new TestCaseSupplier.TypedData(new BytesRef("12/Jul/2022:10:24:10 +0900"), DataType.KEYWORD, "second") |
There was a problem hiding this comment.
nit: we could randomize this a bit (only on the hour of course, no need to complicate it too much)
| @@ -494,6 +494,52 @@ b:datetime | |||
| null | |||
| ; | |||
|
|
|||
| evalDateParseWithTimezone | |||
| required_capability: date_parse_tz | |||
| row s = "12/Jul/2022:10:24:10 +0900" | eval d = date_parse("dd/MMM/yyyy:HH:mm:ss Z", s); | |||
There was a problem hiding this comment.
nit: it would be good to have at least one test that crosses midnight (we could complicate it more with months/years/leap day but IMHO it's overkill)
bpintea
added
the
auto-merge-without-approval
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 19, 2024
This just removes fixing a formatter to a timezone (UTC), allowing `DATE_PARSE` to correctly read timezones. Fixes elastic#117680.
This was referenced Dec 19, 2024
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 19, 2024
This just removes fixing a formatter to a timezone (UTC), allowing `DATE_PARSE` to correctly read timezones. Fixes elastic#117680.
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 19, 2024
This just removes fixing a formatter to a timezone (UTC), allowing `DATE_PARSE` to correctly read timezones. Fixes elastic#117680.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 19, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 19, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 19, 2024
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 23, 2024
Allow warning header for date specifiers that could change in JDK23. Relevant for 8.x BWC tests. Related: elastic#118603 Fixes elastic#119148 Fixes elastic#119151 Fixes elastic#119152 Fixes elastic#119153 Fixes elastic#119154 Fixes elastic#119160 Fixes elastic#119161 Fixes elastic#119162 Fixes elastic#119163 Fixes elastic#119164 Fixes elastic#119165 Fixes elastic#119166 Fixes elastic#119167
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 23, 2024
Allow warning header for date specifiers that could change in JDK23. Relevant for 8.x BWC tests. Related: elastic#118603 Fixes elastic#119148 Fixes elastic#119151 Fixes elastic#119152 Fixes elastic#119153 Fixes elastic#119154 Fixes elastic#119160 Fixes elastic#119161 Fixes elastic#119162 Fixes elastic#119163 Fixes elastic#119164 Fixes elastic#119165 Fixes elastic#119166 Fixes elastic#119167
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 23, 2024
Allow warning header for date specifiers that could change in JDK23. Relevant for 8.x BWC tests. Related: elastic#118603 Fixes elastic#119148 Fixes elastic#119151 Fixes elastic#119152 Fixes elastic#119153 Fixes elastic#119154 Fixes elastic#119160 Fixes elastic#119161 Fixes elastic#119162 Fixes elastic#119163 Fixes elastic#119164 Fixes elastic#119165 Fixes elastic#119166 Fixes elastic#119167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just removes fixing a formatter to a timezone (UTC), allowing
DATE_PARSEto correctly read timezones.Fixes #117680.