-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating inference services API response #118491
Conversation
Hi @ymao1, I've created a changelog YAML for you. |
Pinging @elastic/ml-core (Team:ML) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have a couple of suggestions
The output contains lots of entries like "default_value": null,
. In SettingsConfiguration#toXContent()
please can you wrap writing default_value in a null check.
The service configurations are not sorted as order they are written depends on the iteration order of a map. Sorting the individual configs by service
would make the output more readable.
Updated in 8e1562d
Updated in bc1922d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested locally, works as expected.
❗❗This should not be merged until elastic/kibana#203363 is released to serverless
Resolves https://github.com/elastic/ml-team/issues/1428
Summary
Updates the
GET _inference/_services
API to follow the new agreed upon response format.For the new
updatable
field, I followed the guidance from API docs which saysyou can modify task_settings, secrets (within service_settings), or num_allocations, depending on the specific endpoint service and task_type you’ve created
, so the only fields withupdatable: true
are secret settings field andnum_allocations
.