-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and unmute OperatorPrivilegesIT #117218
Fix and unmute OperatorPrivilegesIT #117218
Conversation
This updates the constants for `OperatorPrivilegesIT` to include the registered actions that were missing and unmutes the test
Pinging @elastic/es-security (Team:Security) |
@@ -358,6 +358,7 @@ public class Constants { | |||
"cluster:monitor/nodes/data_tier_usage", | |||
"cluster:monitor/nodes/features", | |||
"cluster:monitor/nodes/hot_threads", | |||
"cluster:monitor/nodes/index_mode_stats", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This action seems to be only existing in 8.17.+ versions. We should not be backporting it to 8.16.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes for cluster:monitor/xpack/info/logsdb
and cluster:monitor/xpack/usage/logsdb
.
@@ -488,6 +491,7 @@ public class Constants { | |||
"indices:admin/block/add[s]", | |||
"indices:admin/cache/clear", | |||
"indices:admin/data_stream/lazy_rollover", | |||
"indices:admin/data_stream/reindex", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this one seems to be only added in 9.0 with a backport pending to 8.18+ (#116780).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah just added yesterday. The backport to 8.18 is coming soon (#117251).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it will not be backported to 8.17 or earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with a note on backport labels)
Thanks for handling this! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Tim!
Yeah, it's muted on various branches, and failing on others, so I think I'm going to need to go through each one and work out what action is needed. |
This updates the constants for `OperatorPrivilegesIT` to include the registered actions that were missing and unmutes the test Backport of: elastic#117218
This updates the constants for `OperatorPrivilegesIT` to include the registered actions that were missing and unmutes the test Backport of: #117218
This updates the constants for `OperatorPrivilegesIT` to include the registered actions that were missing and unmutes the test
This updates the constants for `OperatorPrivilegesIT` to include the registered actions that were missing and unmutes the test
This updates the constants for
OperatorPrivilegesIT
to include the registered actions that were missing and unmutes the testResolves: #102992