Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip FIPS JVMs in testReloadCredentialsFromKeystore #116814

Conversation

DaveCTurner
Copy link
Contributor

This test doesn't need to run in FIPS mode, and apparently it fails
sometimes, so with this commit we skip it.

Closes #116811

This test doesn't need to run in FIPS mode, and apparently it fails
sometimes, so with this commit we skip it.

Closes elastic#116811
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs :Security/FIPS Running ES in FIPS 140-2 mode v9.0.0 v8.17.0 labels Nov 14, 2024
@DaveCTurner DaveCTurner added the auto-backport Automatically create backport pull requests when merged label Nov 14, 2024
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team Team:Distributed Coordination Meta label for Distributed Coordination team labels Nov 14, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We need to remove the mute from muted-tests.yml as well.

I guess it is possible to make the test work with FIPS. But the value is questionable since this test does not even have security enabled due to its usage of the INGEST_TEST distribution type.

@DaveCTurner DaveCTurner enabled auto-merge (squash) November 19, 2024 09:16
@DaveCTurner DaveCTurner merged commit ea90fbc into elastic:main Nov 19, 2024
22 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 116814

@DaveCTurner DaveCTurner deleted the 2024/11/14/testReloadCredentialsFromKeystore-skip-fips branch November 19, 2024 12:00
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 19, 2024
This test doesn't need to run in FIPS mode, and apparently it fails
sometimes, so with this commit we skip it.

Closes elastic#116811
Backport of elastic#116814 to 8.x
DaveCTurner added a commit that referenced this pull request Nov 19, 2024
This test doesn't need to run in FIPS mode, and apparently it fails
sometimes, so with this commit we skip it.

Closes #116811
Backport of #116814 to 8.x
@ywangd
Copy link
Member

ywangd commented Nov 19, 2024

💚 All backports created successfully

Status Branch Result
8.16

Questions ?

Please refer to the Backport tool documentation

ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Nov 19, 2024
This test doesn't need to run in FIPS mode, and apparently it fails
sometimes, so with this commit we skip it.

Closes elastic#116811

(cherry picked from commit ea90fbc)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Nov 19, 2024
)

This test doesn't need to run in FIPS mode, and apparently it fails
sometimes, so with this commit we skip it.

Closes #116811

(cherry picked from commit ea90fbc)

# Conflicts:
#	muted-tests.yml

Co-authored-by: David Turner <[email protected]>
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Nov 20, 2024
This test doesn't need to run in FIPS mode, and apparently it fails
sometimes, so with this commit we skip it.

Closes elastic#116811
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
This test doesn't need to run in FIPS mode, and apparently it fails
sometimes, so with this commit we skip it.

Closes elastic#116811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs :Security/FIPS Running ES in FIPS 140-2 mode Team:Distributed Coordination Meta label for Distributed Coordination team Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] RepositoryS3RestIT testReloadCredentialsFromKeystore failing
4 participants