Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Optimize threading in AbstractSearchAsyncAction (#113230) #115643

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[8.x] Optimize threading in AbstractSearchAsyncAction (#113230) #115643

merged 1 commit into from
Oct 25, 2024

Conversation

original-brownbear
Copy link
Member

Backports the following commits to 8.x:

@original-brownbear
Optimize threading in AbstractSearchAsyncAction (elastic#113230)
cb37f20 
Forking when an action completes on the current thread is needlessly heavy handed
in preventing stack-overflows. Also, we don't need locking/synchronization
to deal with a worker-count + queue length problem. Both of these allow for
non-trivial optimization even in the current execution model, also this change
helps with moving to a more efficient execution model by saving needless forking to
the search pool in particular.
-> refactored the code to never fork but instead avoid stack-depth issues through use
of a `SubscribableListener`
-> replaced our home brew queue and semaphore combination by JDK primitives which
saves blocking synchronization on task start and completion.
@original-brownbear original-brownbear added :Search Foundations/Search Catch all for Search Foundations >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Oct 25, 2024
@elasticsearchmachine elasticsearchmachine mentioned this pull request Oct 25, 2024
Merged
@elasticsearchmachine elasticsearchmachine merged commit 3cc5796 into elastic:8.x Oct 25, 2024
15 checks passed
@original-brownbear original-brownbear deleted the backport/8.x/pr-113230 branch October 25, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >non-issue :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@original-brownbear @elasticsearchmachine