Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run lookup index YAML with two shards #115608

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 24, 2024

We can randomly inject a global template that defaults to 2 shards instead of 1. This causes the lookup index YAML tests to fail. To avoid this, the change requires specifying the default_shards setting for these tests.

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Oct 24, 2024
@dnhatn dnhatn marked this pull request as ready for review October 24, 2024 23:58
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Oct 24, 2024
@dnhatn dnhatn merged commit 5714b98 into elastic:main Oct 24, 2024
15 of 16 checks passed
@dnhatn dnhatn deleted the no-template-lookup branch October 24, 2024 23:58
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
We can randomly inject a global template that defaults to 2 shards 
instead of 1. This causes the lookup index YAML tests to fail. To avoid 
this, the change requires specifying the default_shards setting for
these tests
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
We can randomly inject a global template that defaults to 2 shards 
instead of 1. This causes the lookup index YAML tests to fail. To avoid 
this, the change requires specifying the default_shards setting for
these tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) needs:triage Requires assignment of a team area label >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants