Fix IPinfo geolocation schema #115147
Merged
Fix IPinfo geolocation schema #115147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are slightly different columns in this sample database than in the one we had been using. Most of the difference is immaterial, but the location columns themselves are named slightly differently, and we need to update our code and tests to match this new schema.
joegallo
added
>bug
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @joegallo, I've created a changelog YAML for you. |
masseyke
approved these changes
Oct 18, 2024
joegallo
added
the
auto-backport
This was referenced Oct 19, 2024
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 19, 2024
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 19, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 19, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 19, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all the example IPinfo database files using the latest and greatest from https://github.com/ipinfo/sample-database/tree/main. The contents of those files are different because of the update (but not the schema), so our tests have been updated to search for different ip addresses and expect different results. In each case, I'm manually searching for an ip address and the result to search for using a dump of the contents of the file with a slight preference towards results that are earlier in the data dump.
This also switches us from one example database to a different one for the Geolocation database -- this example database more closely matches the
standard_location.mmdbdatabase. It also updates our code to match the slightly different schema of this different Geolocation database.