Close exchanges in HttpClientTests #115059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
If I were a betting man, I'd imagine that maybe on 23 there's some kind buffering of the response body that only gets flushed once the exchange is closed. It seems to work both ways pre-23, but on 23 we have to add the close in places where we're not already doing some kind of close on the response OutputStream. (Or something like that, 🤷.) |
|
This test has been muted on |
masseyke
approved these changes
Oct 18, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 18, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 18, 2024
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 23, 2024
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 24, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112618