Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't return TEXT type for functions that take TEXT #114334

Merged
Merged
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2e647cf
Don't return TEXT type for functions that take TEXT
craigtaverner Oct 8, 2024
ff79ec0
Update docs/changelog/114334.yaml
craigtaverner Oct 8, 2024
f7fd864
Remove text from return type documented, and meta-tests
craigtaverner Oct 8, 2024
04d363b
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 8, 2024
aa72517
Support REVERSE
craigtaverner Oct 8, 2024
a9517e1
Merge branch 'esql_functions_never_return_text' of github.com:craigta…
craigtaverner Oct 8, 2024
96e6575
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 8, 2024
3793ffe
Added EsqlCapabilities for reverse function emitting keyword
craigtaverner Oct 9, 2024
a11cd1d
Fixed failing test
craigtaverner Oct 9, 2024
9bdb58a
Fix tests
luigidellaquila Oct 11, 2024
fcc93a1
Expand EsqlCapability to cover all functions now emitting KEYWORD
craigtaverner Oct 11, 2024
7e642ad
More tests failing due to new behaviour
craigtaverner Oct 11, 2024
589f5e2
Remove type assertion for function merged back to 8.x already
craigtaverner Oct 11, 2024
568c069
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 11, 2024
f42533e
Mute yamlRestCompatTest for tests that assert on TEXT/KEYWORD columns
craigtaverner Oct 11, 2024
ca35bec
Re-enable KEYWORD assertion on reverse text, but not values
craigtaverner Oct 11, 2024
b07f6c1
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 18, 2024
de7154d
Cannot skip tests named "values"
craigtaverner Oct 18, 2024
2d93a2c
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 18, 2024
d41e58a
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 20, 2024
f596605
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 22, 2024
bb1edf9
Remove support for ::text type conversion
craigtaverner Oct 22, 2024
9b31a8f
Simplify the code to check if a return type is Text or not
craigtaverner Oct 22, 2024
c6ed4ef
Fix failing test
craigtaverner Oct 22, 2024
0fa28ad
Remove TEXT output from CASE, GREATEST, LEAST
craigtaverner Oct 23, 2024
84e045e
Remove TEXT output from COALESCE
craigtaverner Oct 23, 2024
ab13bba
Remove TEXT output from MV_APPEND
craigtaverner Oct 23, 2024
7301ea6
Remove TEXT output from MV_SLICE and MV_SORT
craigtaverner Oct 23, 2024
44a7280
Fixed failing tests by basing new TEX/KEYWORD combinations on a simpl…
craigtaverner Oct 23, 2024
0ae49af
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 23, 2024
db61084
Fixed remaining ternary check for TEXT
craigtaverner Oct 23, 2024
64ff151
Added fixed json after running all esql tests locally
craigtaverner Oct 23, 2024
04134b5
Update docs/changelog/114334.yaml
craigtaverner Oct 24, 2024
8f3bfc3
Removed unnecessary calls to noText in test cases
craigtaverner Oct 24, 2024
cfba4db
Merge branch 'esql_functions_never_return_text' of github.com:craigta…
craigtaverner Oct 24, 2024
fb2545d
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 24, 2024
853423f
Merge remote-tracking branch 'origin/main' into esql_functions_never_…
craigtaverner Oct 24, 2024
8d03838
Removed three remaining ternary functions, using noText instead
craigtaverner Oct 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/changelog/114334.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
pr: 114334
summary: Don't return TEXT type for functions that take TEXT
area: ES|QL
type: bug
issues:
- 111537
- 114333
52 changes: 50 additions & 2 deletions docs/reference/esql/functions/kibana/definition/case.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/esql/functions/kibana/definition/coalesce.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/esql/functions/kibana/definition/greatest.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/esql/functions/kibana/definition/least.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/kibana/definition/ltrim.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/kibana/definition/max.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/kibana/definition/min.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/kibana/definition/rtrim.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/kibana/definition/top.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/kibana/definition/trim.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion docs/reference/esql/functions/kibana/inline_cast.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions docs/reference/esql/functions/types/case.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/esql/functions/types/coalesce.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/esql/functions/types/greatest.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/esql/functions/types/least.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/types/ltrim.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/types/max.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/types/min.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/types/mv_append.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/types/mv_dedupe.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/types/mv_first.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading