Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit deprecation warning when executing one of the rollup APIs (Attempt 2) #113131

Merged
merged 13 commits into from
Jan 29, 2025
Merged

Emit deprecation warning when executing one of the rollup APIs (Attempt 2) #113131

merged 13 commits into from
Jan 29, 2025

Conversation

martijnvg
Copy link
Member

Relates to #112690

@martijnvg martijnvg added >non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data test-full-bwc Trigger full BWC version matrix tests test-update-serverless labels Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Hi @martijnvg, I've created a changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@martijnvg martijnvg marked this pull request as ready for review January 17, 2025 16:43
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@martijnvg martijnvg removed the v8.18.0 label Jan 27, 2025
kkrik-es
kkrik-es approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check serverless too, with an empty pr using the same branch name?

@martijnvg
Copy link
Member Author

Check serverless too, with an empty pr using the same branch name?

Rollup is disabled in serverless, the module doesn't get loaded. The rollup tests are muted in serverless for that reason.
So I don't think this is needed?

@martijnvg martijnvg merged commit 8185caf into elastic:main Jan 29, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrik-es kkrik-es kkrik-es approved these changes

Assignees
No one assigned
Labels
>deprecation :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:StorageEngine test-full-bwc Trigger full BWC version matrix tests test-update-serverless v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martijnvg @elasticsearchmachine @kkrik-es