Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES|QL: Fix ResolvedEnrichPolicy serialization (bwc) in v 8.15 #112985

Merged
merged 3 commits into from
Sep 17, 2024
Merged

ES|QL: Fix ResolvedEnrichPolicy serialization (bwc) in v 8.15 #112985

merged 3 commits into from
Sep 17, 2024

Conversation

luigidellaquila
Copy link
Contributor

@luigidellaquila luigidellaquila commented Sep 17, 2024 •
edited
Loading

Before the fix introduced by #112865, ResolvedEnrichPolicy did not serialize EsField as a NamedWriteable

Fixes #112968

@luigidellaquila luigidellaquila added >bug test-full-bwc Trigger full BWC version matrix tests :Analytics/ES|QL AKA ESQL labels Sep 17, 2024
@elasticsearchmachine elasticsearchmachine added v8.15.2 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Sep 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@luigidellaquila luigidellaquila mentioned this pull request Sep 17, 2024
Closed
@elasticsearchmachine
Copy link
Collaborator

Hi @luigidellaquila, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Hi @luigidellaquila, I've updated the changelog YAML for you.

alex-spies
alex-spies approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also checked and couldn't find any other places where EsFields were deserialized directly rather than as named writables.

@luigidellaquila luigidellaquila merged commit 5d8a04b into elastic:8.15 Sep 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-spies alex-spies alex-spies approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-full-bwc Trigger full BWC version matrix tests v8.15.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luigidellaquila @elasticsearchmachine @alex-spies