Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit deprecation warning when executing one of the rollup APIs #112807

Merged
merged 12 commits into from
Sep 17, 2024

Conversation

martijnvg
Copy link
Member

@martijnvg martijnvg commented Sep 12, 2024

Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated.

Relates to #112690

@martijnvg martijnvg added >non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v8.16.0 v8.15.2 v9.0.0 labels Sep 12, 2024
@martijnvg martijnvg marked this pull request as ready for review September 17, 2024 14:00
@martijnvg martijnvg requested a review from a team as a code owner September 17, 2024 14:00
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@martijnvg martijnvg merged commit 3d6e9a2 into elastic:main Sep 17, 2024
15 checks passed
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Sep 17, 2024
…ic#112807)

Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated.

Relates to elastic#112690
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x
8.15 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 112807

martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Sep 17, 2024
Backporting elastic#112807 to 8.15 branch.
Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated.

Relates to elastic#112690
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Sep 17, 2024
elasticsearchmachine pushed a commit that referenced this pull request Sep 17, 2024
#112807)" (#113047)

This reverts commit 3d6e9a2, because
the original change is causing xpack rest test failures in other
repositories.
elasticsearchmachine pushed a commit that referenced this pull request Sep 17, 2024
…#113042)

* [8.15] Emit deprecation warning when executing one of the rollup APIs

Backporting #112807 to 8.15 branch.
Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated.

Relates to #112690

* Fixed compile errors after cherry-picking from main branch.

* fix issue after merging

* added some more allowed warnings
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Sep 18, 2024
…ic#112807)

Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated.

Relates to elastic#112690
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Sep 18, 2024
elastic#112807)" (elastic#113047)

This reverts commit 3d6e9a2, because
the original change is causing xpack rest test failures in other
repositories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants