-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit deprecation warning when executing one of the rollup APIs #112807
Merged
martijnvg
merged 12 commits into
elastic:main
from
martijnvg:rollup_deprecation_warnings
Sep 17, 2024
Merged
Emit deprecation warning when executing one of the rollup APIs #112807
martijnvg
merged 12 commits into
elastic:main
from
martijnvg:rollup_deprecation_warnings
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>non-issue
:StorageEngine/Rollup
Turn fine-grained time-based data into coarser-grained data
v8.16.0
v8.15.2
v9.0.0
labels
Sep 12, 2024
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 17, 2024
…ic#112807) Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated. Relates to elastic#112690
💔 Backport failed
You can use sqren/backport to manually backport by running |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 17, 2024
Backporting elastic#112807 to 8.15 branch. Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated. Relates to elastic#112690
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 17, 2024
elastic#112807)" This reverts commit 3d6e9a2.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 17, 2024
…#113042) * [8.15] Emit deprecation warning when executing one of the rollup APIs Backporting #112807 to 8.15 branch. Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated. Relates to #112690 * Fixed compile errors after cherry-picking from main branch. * fix issue after merging * added some more allowed warnings
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 18, 2024
…ic#112807) Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated. Relates to elastic#112690
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 18, 2024
elastic#112807)" (elastic#113047) This reverts commit 3d6e9a2, because the original change is causing xpack rest test failures in other repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport pending
>non-issue
:StorageEngine/Rollup
Turn fine-grained time-based data into coarser-grained data
Team:StorageEngine
v8.15.2
v8.16.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently none of the rollup APIs deprecation warning. Only the reference docs indicate that rollup has been deprecated.
Relates to #112690