Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default locale of date processors to ENGLISH #112796

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Change default locale of date processors to ENGLISH #112796

merged 2 commits into from
Sep 24, 2024

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Sep 12, 2024 •
edited
Loading

This resolves #112692

Field mappers are covered by #112799

@thecoop thecoop added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.16.0 labels Sep 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v9.0.0 labels Sep 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've updated the changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@thecoop
Copy link
Member Author

thecoop commented Sep 12, 2024 •
edited
Loading

The test failures is due to IsoCalendarDataProvider, introduced by #48209, only being specified for ROOT - this means the first day-of-week is Sunday rather than Monday, changing the week-of-year calculations. See #112801 for the immediate fix.

@thecoop thecoop mentioned this pull request Sep 12, 2024
Closed
@thecoop thecoop added the WIP label Sep 13, 2024
@dakrone
Copy link
Member

dakrone commented Sep 18, 2024

@elasticmachine update branch

@joegallo joegallo self-assigned this Sep 19, 2024
@joegallo joegallo self-requested a review September 19, 2024 19:18
@thecoop thecoop force-pushed the english-date-processors branch from fd80a1a to 0f51fd1 Compare September 23, 2024 10:08
@thecoop thecoop requested a review from a team September 23, 2024 12:33
@thecoop thecoop mentioned this pull request Sep 23, 2024
Merged
joegallo
joegallo approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

We'll need to add a docs PR that fixes the previously-wrong documentation on pre-8.16 branches. That is, we documented that the default locale for date processors was english, but it's always been root. I'll take that as a task for 8.16.

@thecoop
Copy link
Member Author

thecoop commented Sep 24, 2024

@elasticmachine update branch

@thecoop thecoop added the auto-backport Automatically create backport pull requests when merged label Sep 24, 2024
@thecoop thecoop merged commit d582db2 into elastic:main Sep 24, 2024
16 checks passed
@thecoop thecoop deleted the english-date-processors branch September 24, 2024 08:54
@thecoop thecoop mentioned this pull request Sep 24, 2024
Merged
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Sep 24, 2024
@thecoop
Change default locale of date processors to ENGLISH (elastic#112796)
9e0e66f 
It is English in the docs, so this fixes the code to match the docs. Note that this really impacts Elasticsearch when run on JDK 23 with the CLDR locale database, as in the COMPAT database pre-23, root and en are essentially the same.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

thecoop added a commit that referenced this pull request Sep 24, 2024
@thecoop
Change default locale of date processors to ENGLISH (#112796) (#113438)
8c81222 
It is English in the docs, so this fixes the code to match the docs. Note that this really impacts Elasticsearch when run on JDK 23 with the CLDR locale database, as in the COMPAT database pre-23, root and en are essentially the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegallo joegallo joegallo approved these changes

Assignees

@joegallo joegallo

Labels
auto-backport Automatically create backport pull requests when merged blocker :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >non-issue Team:Data Management Meta label for data/management team test-update-serverless v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default locale of date processors to english
5 participants
@thecoop @elasticsearchmachine @dakrone @joegallo @elasticmachine