Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup shutdown module bwc in v9 #112793

Merged

Conversation

DaveCTurner
Copy link
Contributor

Removes a bunch of now-unnecessary bwc code in the shutdown module.

Removes a bunch of now-unnecessary bwc code in the shutdown module.
@DaveCTurner DaveCTurner added >non-issue :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown v9.0.0 labels Sep 12, 2024
@DaveCTurner DaveCTurner requested a review from thecoop September 12, 2024 08:57
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Sep 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@thecoop thecoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first of many, many, many refactors

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 12, 2024
@DaveCTurner
Copy link
Contributor Author

The first of many, many, many refactors

Quoting Mandos, not the first (see #112790)

@elasticsearchmachine elasticsearchmachine merged commit d1d2977 into elastic:main Sep 12, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the 2024/09/12/shutdown-v9-bwc branch September 12, 2024 09:58
davidkyle pushed a commit that referenced this pull request Sep 12, 2024
Removes a bunch of now-unnecessary bwc code in the shutdown module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown >non-issue Team:Core/Infra Meta label for core/infra team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants