Make two SubReaderWrapper implementations singletons #112596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No state in either of these, no need to recreate them for every directory. Saves a few cycles and makes it more obvious that there's no state in these.
original-brownbear
added
>non-issue
:Search Foundations/Search
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
Team:Search Foundations
tlrx
approved these changes
Sep 9, 2024
| final int numDocs = segmentReader.maxDoc() - segmentReader.getSegmentInfo().getDelCount(); | ||
| assert numDocs == popCount(hardLiveDocs) : numDocs + " != " + popCount(hardLiveDocs); | ||
| return new LeafReaderWithLiveDocs(segmentReader, hardLiveDocs, numDocs); | ||
| private static final SubReaderWrapper SUB_READER_WRAPPER = new SubReaderWrapper() { |
There was a problem hiding this comment.
Suggested change
| private static final SubReaderWrapper SUB_READER_WRAPPER = new SubReaderWrapper() { | |
| private static final SubReaderWrapper ALL_LIVE_DOCS_SUB_READER_WRAPPER = new SubReaderWrapper() { |
original-brownbear
added
the
auto-merge-without-approval
|
Thanks Tanguy! |
|
@elasticmachine update branch |
davidkyle
pushed a commit
that referenced
this pull request
Sep 12, 2024
random find: No state in either of these, no need to recreate them for every directory. Saves a few cycles and makes it more obvious that there's no state in these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random find:
No state in either of these, no need to recreate them for every directory. Saves a few cycles and makes it more obvious that there's no state in these.