Exclude version conflict errors from failure store #112537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>non-issue
:Data Management/Data streams
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
Team:Data Management
|
@elasticmachine upgrade branch |
gmarouli
added
the
auto-merge-without-approval
|
@elasticmachine update branch |
pulak777
pushed a commit
to pulak777/elasticsearch
that referenced
this pull request
Sep 9, 2024
When indexing to a data stream with a failure store it's possible to get
a version conflict. The reproduction path is the following:
```
PUT /_bulk
{"create":{"_index": "my-ds-with-fs", "_id": "1"}}
{"@timestamp": "2022-01-01", "baz": "quick", "a": "brown", "b": "fox"}
{"create":{"_index": "my-ds-with-fs", "_id": "1"}}
{"@timestamp": "2022-01-01", "baz": "lazy", "a": "dog"}
```
We would like the second document to not be sent to the failure store
and return an error to the user:
```
{
"errors" : true,
"took" : 409,
"items" : [
{
"create" : {
"_index" : ".ds-my-ds-with-fs-xxxxx-xxxx",
"_id" : "1",
"_version" : 1,
"result" : "created",
"_shards" : {
"total" : 2,
"successful" : 1,
"failed" : 0
},
"_seq_no" : 0,
"_primary_term" : 1,
"status" : 201
}
},
{
"create" : {
"_index" : ".ds-my-ds-with-fs-xxxxx-xxxx",
"_id" : "1",
"status" : 409,
"error" : {
"type" : "version_conflict_engine_exception",
"reason" : "[1]: version conflict, document already exists (current version [1])",
"index_uuid" : ".....",
"shard" : "0",
"index" : ".ds-my-ds-with-fs-xxxxx-xxxx"
}
}
}
]
}
```
The version conflict doc is counted as a rejected doc in APM telemetry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When indexing to a data stream with a failure store it's possible to get a version conflict. The reproduction path is the following:
We would like the second document to not be sent to the failure store and return an error to the user:
The version conflict doc is counted as a rejected doc in APM telemetry.