Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two speedups to IndexNameExpressionResolver #112486

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

original-brownbear
Copy link
Member

Two obvious speedups to the IndexNameExpressionResolver where we can defer an expensive lookup from either the indices lookup or the thread context to if and when we actually need it.

Two obvious speedups to the IndexNameExpressionResolver where we can
defer an expensive lookup from either the indices lookup or the thread
context to if and when we actually need it.
@original-brownbear original-brownbear added >non-issue :Data Management/Indices APIs APIs to create and manage indices and templates labels Sep 4, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Sep 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @original-brownbear!

@original-brownbear
Copy link
Member Author

npnp + thanks Niels!

@original-brownbear original-brownbear added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 4, 2024
@original-brownbear
Copy link
Member Author

@elasticmachine update branch

@original-brownbear
Copy link
Member Author

Thanks Niels!

@original-brownbear original-brownbear merged commit 6235795 into elastic:main Sep 11, 2024
14 of 15 checks passed
@original-brownbear original-brownbear deleted the two-fixes-iner branch September 11, 2024 11:04
davidkyle pushed a commit that referenced this pull request Sep 12, 2024
Two obvious speedups to the IndexNameExpressionResolver where we can
defer an expensive lookup from either the indices lookup or the thread
context to if and when we actually need it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Indices APIs APIs to create and manage indices and templates >non-issue Team:Data Management Meta label for data/management team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants