-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two speedups to IndexNameExpressionResolver #112486
Merged
original-brownbear
merged 3 commits into
elastic:main
from
original-brownbear:two-fixes-iner
Sep 11, 2024
Merged
Two speedups to IndexNameExpressionResolver #112486
original-brownbear
merged 3 commits into
elastic:main
from
original-brownbear:two-fixes-iner
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two obvious speedups to the IndexNameExpressionResolver where we can defer an expensive lookup from either the indices lookup or the thread context to if and when we actually need it.
original-brownbear
added
>non-issue
:Data Management/Indices APIs
APIs to create and manage indices and templates
labels
Sep 4, 2024
elasticsearchmachine
added
the
Team:Data Management
Meta label for data/management team
label
Sep 4, 2024
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @original-brownbear!
npnp + thanks Niels! |
original-brownbear
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Sep 4, 2024
@elasticmachine update branch |
Thanks Niels! |
davidkyle
pushed a commit
that referenced
this pull request
Sep 12, 2024
Two obvious speedups to the IndexNameExpressionResolver where we can defer an expensive lookup from either the indices lookup or the thread context to if and when we actually need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Data Management/Indices APIs
APIs to create and manage indices and templates
>non-issue
Team:Data Management
Meta label for data/management team
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two obvious speedups to the IndexNameExpressionResolver where we can defer an expensive lookup from either the indices lookup or the thread context to if and when we actually need it.