Force using the last centroid during merging #111644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
added
>bug
:Analytics/Aggregations
|
Hi @kkrik-es, I've created a changelog YAML for you. |
kkrik-es
commented
Aug 6, 2024
| @@ -152,7 +152,7 @@ public void testQuantile() { | |||
| hist2.compress(); | |||
| double x1 = hist1.quantile(0.5); | |||
| double x2 = hist2.quantile(0.5); | |||
| assertEquals(Dist.quantile(0.5, data), x1, 0.2); | |||
| assertEquals(Dist.quantile(0.5, data), x1, 0.25); | |||
There was a problem hiding this comment.
This is orthogonal, noticed it in CI: https://gradle-enterprise.elastic.co/s/36zxzfevfwrcc
Verified that it happens regardless of the change in MergingDigest.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
not-napoleon
approved these changes
Aug 8, 2024
|
Thanks Mark! |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Aug 9, 2024
* upstream/main: (22 commits) Prune changelogs after 8.15.0 release Bump versions after 8.15.0 release EIS integration (elastic#111154) Skip LOOKUP/INLINESTATS cases unless on snapshot (elastic#111755) Always enforce strict role validation (elastic#111056) Mute org.elasticsearch.xpack.esql.analysis.VerifierTests testUnsupportedAndMultiTypedFields elastic#111753 [ML] Force time shift integration test (elastic#111620) ESQL: Add tests for sort, where with unsupported type (elastic#111737) [ML] Force time shift documentation (elastic#111668) Fix remote cluster credential secure settings reload (elastic#111535) ESQL: Fix for overzealous validation in case of invalid mapped fields (elastic#111475) Pass allow security manager flag in gradle test policy setup plugin (elastic#111725) Rename streamContent/Separator to bulkContent/Separator (elastic#111716) Mute org.elasticsearch.tdigest.ComparisonTests testSparseGaussianDistribution elastic#111721 Remove 8.14 from branches.json Only emit product origin in deprecation log if present (elastic#111683) Forward port release notes for v8.15.0 (elastic#111714) [ES|QL] Combine Disjunctive CIDRMatch (elastic#111501) ESQL: Remove qualifier from attrs (elastic#110581) Force using the last centroid during merging (elastic#111644) ... # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferenceNamedWriteablesProvider.java
This was referenced Aug 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2024
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
* Force using the last centroid during merging * Update docs/changelog/111644.yaml * spotless * add asserts in test
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 5, 2024
* Force using the last centroid during merging * Update docs/changelog/111644.yaml * spotless * add asserts in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MergingDigest uses pre-allocated arrays for constant memory footprint and improved performance. Points get added to an intermediate buffer that gets merged to the canonical arrays of means and weights (constituting the centroids). During merging, the values in the latter arrays get updated with the merged values. However, the current logic may try to update a value after the array bound, for values in the very low or very high percentiles. This PR fixes this.
Fixes #111065