[ES|QL] Generate docs for unregistered esql functions from annotations #108749
Conversation
fang-xing-esql
added
>docs
|
Documentation preview: |
elasticsearchmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
...test/java/org/elasticsearch/xpack/esql/expression/predicate/operator/comparison/InTests.java
Outdated
Show resolved
Hide resolved
...test/java/org/elasticsearch/xpack/esql/expression/predicate/operator/comparison/InTests.java
Outdated
Show resolved
Hide resolved
|
The docs don't quite look right: |
|
This is heroic work, btw. Thanks so much for it. |
I'll remove one of them. |
|
Pinging @elastic/kibana-esql (ES|QL-ui) |
| def(Split.class, Split::new, "split") } }; | ||
| def(Split.class, Split::new, "split") }, | ||
| // Operators | ||
| new FunctionDefinition[] { def(In.class, In::new, "in") } }; |
There was a problem hiding this comment.
Does this mean you can use it like WHERE IN(blah, "foo", "bar", "baz") now? Do we want that?
There was a problem hiding this comment.
Does this mean you can use it like
WHERE IN(blah, "foo", "bar", "baz")now? Do we want that?
I don't think we want this syntax, it is just for doc generation.
There was a problem hiding this comment.
Probably best to zap this from EsqlFunctionRegistry then.
|
Rendered docs look great! |
Thank you for reviewing @nik9000 ! |
elastic#108749) * render docs for operators
This is a subtask of #104247 , covers operators that are unregistered functions.