-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] clarify that the repo location setting accepts only one value #108267
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the way you handled this. LGTM pending clean docs-ci
@@ -33,7 +33,8 @@ in snapshots. Data files are not compressed. Defaults to `true`. | |||
(Required, string) | |||
Location of the shared filesystem used to store and retrieve snapshots. This | |||
location must be registered in the `path.repo` setting on all master and data | |||
nodes in the cluster. | |||
nodes in the cluster. | |||
Unlike `path.repo`, this setting supports only a single file path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it when people put the "only" in the right place. :-) This is awesome.
Fixes #97339
Clarifies that
location
should be a single value.To reviewers: given that multiple values aren't explicitly rejected, is
accepts
ok wording?To avoid making this issue bigger than it should be, I chose to present the "single value" requirement in contrast to the
path.repo
setting it references. hopefully this will make it so that we don't have to clarify the entire bug in the docs.