Sort time series indices by time range in GetDataStreams API #107967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @lkts, I've created a changelog YAML for you. |
martijnvg
reviewed
Apr 29, 2024
| currentMergedRange = new Tuple<>(currentMergedRange.v1(), end); | ||
| } else if (currentMergedRange.v2().compareTo(start) < 0) { | ||
| mergedRanges.add(currentMergedRange); | ||
| currentMergedRange = new Tuple<>(start, end); | ||
| } else { | ||
| String message = "previous backing index [" |
There was a problem hiding this comment.
With the indices getting sorted, I think don't we will ever log this warning? Maybe we should remove it and replace this with an assert?
There was a problem hiding this comment.
Yes, this is a "should never happen" thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this logic assumed that time series indices are sorted by their time series range. This is problematic because data stream APIs don't actually enforce this invariant. As seen in below issues it is possible to add an index to data stream that will break the sort order either manually or via DSL.
This PR simply sorts indices in needed order before working with them. It seems appropriate given that this API is not performance sensitive.
Closes #102088, #106890.