Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semantic_text field mapping #107519
semantic_text field mapping #107519
Changes from 14 commits
db9a383
78f8880
7c42501
faef7e2
3359c9a
d4fdeb7
59bb7ae
3b8c49e
3859fad
eacd6ad
92cdfa8
914ce1c
db36d14
b2ab726
b307a76
d565c55
b3246a6
6a32de2
c2ab40f
11d6b3c
f8dfd9c
251ddb5
0417268
b382b3b
60f5e72
fad7ab6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test here that ensures the
InferenceFieldMapper
logic is correct? Generally this is done by making a small test only plugin that provides a mapper that satisfies thisInferenceFieldMapper
interface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I've added them in a new test class -
MappingLookupInferenceFieldMapperTests
. LMKWYT!