Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiling] Annotate TODOs for 9.0.0 upgrade #107150

Merged

Conversation

danielmitterdorfer
Copy link
Member

As suggested by David in #106592, we're adding the annotation @UpdateForV9 to all places in the Universal Profiling plugin that can be removed once we move to 9.0.0.

Relates #106592

As suggested by David in elastic#106592, we're adding the annotation
`@UpdateForV9` to all places in the Universal Profiling plugin that
can be removed once we move to 9.0.0.

Relates elastic#106592
@danielmitterdorfer danielmitterdorfer added >non-issue :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure v8.14.0 labels Apr 5, 2024
@elasticsearchmachine elasticsearchmachine added the Team:obs-knowledge Meta label for Observability Knowledge team label Apr 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@danielmitterdorfer
Copy link
Member Author

I propose that we:

  • move to this approach for tracking 9.0.0 related cleanups (as it's the established practice in the code base and allows to quickly identify the exact places that need to be cleaned up),
  • close all issues that are mentioned as subtasks in Universal Profiling cleanups for 9.0.0 #106592.

Up for discussion is whether we keep #106592 open as a placeholder issue or whether we solely rely on the annotation. I'm fine either way.

@rockdaboot
Copy link
Contributor

I propose that we:

* move to this approach for tracking 9.0.0 related cleanups (as it's the established practice in the code base and allows to quickly identify the exact places that need to be cleaned up),

* close all issues that are mentioned as subtasks in [Universal Profiling cleanups for 9.0.0 #106592](https://github.com/elastic/elasticsearch/issues/106592).

Up for discussion is whether we keep #106592 open as a placeholder issue or whether we solely rely on the annotation. I'm fine either way.

I think the annotation alone serves the purpose. We can close the placeholder issue, IMO.

@danielmitterdorfer
Copy link
Member Author

I think the annotation alone serves the purpose. We can close the placeholder issue, IMO.

Cool, that works for me. I'll close all issues then after I've merged the PR. Thanks for the quick response!

@danielmitterdorfer danielmitterdorfer merged commit cd6af63 into elastic:main Apr 5, 2024
14 checks passed
@danielmitterdorfer danielmitterdorfer deleted the profiling-annotate-v9 branch April 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue Team:obs-knowledge Meta label for Observability Knowledge team :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants