ESQL: Move expression classes into common package #105407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-spies
force-pushed
the
refactor-esql-exprs
branch
from
ee6800a to
e0643a6
Compare
|
Reviving this. Since the conflicts were too many, I started anew, branching from current main. |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
commented
Apr 30, 2024
Comment on lines
+131
to
+139
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.Equals; | ||
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.EsqlBinaryComparison; | ||
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.GreaterThan; | ||
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.GreaterThanOrEqual; | ||
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.In; | ||
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.InsensitiveEquals; | ||
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.LessThan; | ||
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.LessThanOrEqual; | ||
| import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.NotEquals; |
There was a problem hiding this comment.
This here is subtle. Luckily, the serialization uses the plain class name and thus shouldn't be affected by this refactoring - similar to this change in #107789.
not-napoleon
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some expressions both in
org.elasticsearch.xpack.esql.evaluatorandorg.elasticsearch.xpack.esql.expression.Move them all into
org.elasticsearch.xpack.esql.expression.All changed lines are mechanical.