Find break limits for DocBlock tests on fly #104213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
reviewed
Jan 11, 2024
|
|
||
| public void testBuildBreaks() { | ||
| testBuildBreaks(ByteSizeValue.ofBytes(between(0, MAX_BUILD_BREAKS_LIMIT))); | ||
| testBuildBreaks(ByteSizeValue.ofBytes(randomLongBetween(0, MAX_BUILD_BREAKS_LIMIT))); | ||
| } | ||
|
|
||
| public void testBuildBreaksMax() { | ||
| testBuildBreaks(ByteSizeValue.ofBytes(MAX_BUILD_BREAKS_LIMIT)); | ||
| } |
There was a problem hiding this comment.
I don't think we need the MAX limit test if we're going to find this on the fly. The act of finding it confirms that it breaks.
| private static long MAX_SHARD_SEGMENT_DOC_MAP_BREAKS = -1; | ||
|
|
||
| @Before | ||
| public void calculateBreakLimit() { |
There was a problem hiding this comment.
I'd move this to the tests that need them. If the build process doesn't properly release on failure this could leave behind un-released blocks. Better to have that fail in the test, i think.
|
@nik9000 I've reworked these tests as you suggested. Can you take another look? Thanks! |
|
Thank you, Nik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failure is related to #104159, where we had an overestimate of the RAM usage for X-ArrayVector. Instead of updating the break limits, this PR uses the breaker utility that @nik9000 wrote to dynamically compute the limits on-the-fly.
Closes #104191