Re-enable HeapAttackIT #104107
Merged
Re-enable HeapAttackIT #104107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
dump-heap-attack
branch
from
49414e5 to
dea08cf
Compare
dnhatn
force-pushed
the
dump-heap-attack
branch
from
039bdec to
5ffdfa2
Compare
dnhatn
force-pushed
the
dump-heap-attack
branch
from
5ffdfa2 to
3c03315
Compare
dnhatn
added
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
dnhatn
commented
Jan 10, 2024
| @@ -5,6 +5,13 @@ | |||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | |||
| * Side Public License, v 1. | |||
| */ | |||
| import org.elasticsearch.gradle.internal.info.BuildParams | |||
|
|
|||
| apply plugin: 'elasticsearch.legacy-yaml-rest-test' | |||
There was a problem hiding this comment.
This was moved from the parent module.
| @@ -6,6 +6,13 @@ | |||
| * Side Public License, v 1. | |||
| */ | |||
|
|
|||
| import org.elasticsearch.gradle.internal.info.BuildParams | |||
| apply plugin: 'elasticsearch.legacy-yaml-rest-test' | |||
There was a problem hiding this comment.
This also was moved from the parent module.
mark-vieira
approved these changes
Jan 10, 2024
nik9000
approved these changes
Jan 10, 2024
| List<int[]> values = new ArrayList<>(); | ||
| return channel -> { | ||
| while (true) { | ||
| values.add(new int[1024 * 1024]); |
|
@mark-vieira @nik9000 Thanks for reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables ESQL heap attack tests. I have run this suite over 500 iterations with different hardware configurations for the last two days, and all have been successful with the changes in #104159.
Additionally, this PR adds an action that can trigger OOM to generate a heap dump if a test takes more than 5 minutes. I've seen cases (previously with our CI) where the test didn't result in OOM but was taking too long. Having the ability to inspect the heap in such cases would be beneficial.
Closes #103527
Closes #100678