Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc+] Add Secure Connection to Setup CCR Tutorial #103237

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

stefnestor
Copy link
Contributor

👋🏼 howdy, team!

Our "setup CCR" tutorial skips over (sometimes) needing to secure the remote connection. I tried to find a natural spot for it, but kindly move as desired.

TIA! cc: @Ca2Patton

👋🏼 howdy, team!

Our "setup CCR" [tutorial](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/ccr-getting-started-tutorial.html) skips over (sometimes) needing to [secure the remote connection](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/remote-clusters-security.html). I tried to find a natural spot for it, but kindly move as desired.

TIA! cc: @Ca2Patton
@stefnestor stefnestor added >docs General docs changes Team:Docs Meta label for docs team labels Dec 9, 2023
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Documentation preview:

@stefnestor stefnestor added the >bug label Dec 9, 2023
@elasticsearchmachine
Copy link
Collaborator

@stefnestor please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added v8.13.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 9, 2023
@stefnestor
Copy link
Contributor Author

Bump @elastic/es-docs 🙏🏽

@leemthompo
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@@ -90,6 +90,7 @@ image::images/ccr-tutorial-clusters.png[ClusterA contains the leader index and C

To configure a remote cluster from Stack Management in {kib}:

. Setup a <<remote-clusters-security,secure connection>> as needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefnestor this ID doesn't exist per the buildkite failed build error message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @leemthompo ! That'll be because the docs reorganized the pages since when I filed the PR, sorry. It looks like your team moved the section to here with id reference add-remote-clusters.

I'm unfamiliar with editing a branch after filing since the guide is fully UI, but I expect it'll be easy if you'll give me a couple hours to figure it out after my next call ends :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay fixed 🙏

@leemthompo
Copy link
Contributor

run docs-build

@stefnestor
Copy link
Contributor Author

Haha, sorry, @leemthompo could you help me again? I might not be as good at fixing it as I'd guessed 🙈

@leemthompo leemthompo added auto-backport-and-merge v8.13.0 v8.14.0 and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 30, 2024
@leemthompo
Copy link
Contributor

run docs-build

@leemthompo
Copy link
Contributor

@shainaraskas you might be able to diagnose the build error here :)

@shainaraskas
Copy link
Contributor

I'm going to rebase this because of its age

Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is green now, so you're good to merge after you accept that little grammar thingy!

docs/reference/ccr/getting-started.asciidoc Outdated Show resolved Hide resolved
@leemthompo
Copy link
Contributor

🚀

@leemthompo leemthompo merged commit 5b28d3b into main May 3, 2024
6 checks passed
@leemthompo leemthompo deleted the stefnestor-patch-1 branch May 3, 2024 07:13
stefnestor added a commit to stefnestor/elasticsearch that referenced this pull request May 3, 2024
stefnestor added a commit to stefnestor/elasticsearch that referenced this pull request May 3, 2024
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.13
8.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug >docs General docs changes Team:Docs Meta label for docs team v8.13.0 v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants