Refresh if many deletes in a row use up too much version map RAM #10312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM in general - any change we can get a unittest triggering this? maybe in |
|
@s1monw I added a test case ... I think it's ready. |
|
LGTM thanks mike |
mikemccand
added a commit
that referenced
this pull request
Mar 30, 2015
…is using too much RAM We already force a refresh in index/create ops, to clear version map when it's using too much RAM, but we were failing to do this for deletes, so an app that does tons of deletes with no indexing, and has set refresh_interval to -1, would have version map using unbounded RAM. Closes #10312
mikemccand
added a commit
that referenced
this pull request
Mar 30, 2015
…is using too much RAM We already force a refresh in index/create ops, to clear version map when it's using too much RAM, but we were failing to do this for deletes, so an app that does tons of deletes with no indexing, and has set refresh_interval to -1, would have version map using unbounded RAM. Closes #10312
clintongormley
added
>enhancement
:Core/Infra/Core
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…is using too much RAM We already force a refresh in index/create ops, to clear version map when it's using too much RAM, but we were failing to do this for deletes, so an app that does tons of deletes with no indexing, and has set refresh_interval to -1, would have version map using unbounded RAM. Closes elastic#10312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digging into #7052 I noticed that if an app does zillions of "delete by IDs" in a row, we fail to trigger a refresh when the version map is using too much RAM...