Extract repositories metrics into its own class #103034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a follow up of elastic#102505 (comment) that move the repositories metrics management into its own class which is then passed around instead of relying on the raw meterRegistry and string metric names.
ywangd
added
:Distributed Indexing/Distributed
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywangd
commented
Dec 6, 2023
| private final LongHistogram exceptionHistogram; | ||
| private final LongHistogram throttleHistogram; | ||
|
|
||
| public RepositoriesMetrics(MeterRegistry meterRegistry) { |
There was a problem hiding this comment.
This is the new class. Everything else is cascading changes
There was a problem hiding this comment.
Considering its structure is there a value in converting this class to a record and replace constructor with a static factory?
This way we will not need to declare getters
There was a problem hiding this comment.
Sure I changed it to be a record.
idegtiarenko
approved these changes
Dec 6, 2023
|
@elasticmachine run elasticsearch-ci/part-3 |
ywangd
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of
#102505 (comment) that move the repositories metrics management into its own class which is then passed around instead of relying on the raw meterRegistry and string metric names.