Repo analysis: allow configuration of register ops #102051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `?register_operation_count` parameter that allows to control the number of register operations separately from the number of regular blob operations.
DaveCTurner
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Documentation preview: |
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
ywangd
reviewed
Nov 13, 2023
.../src/main/java/org/elasticsearch/repositories/blobstore/testkit/RepositoryAnalyzeAction.java
Outdated
Show resolved
Hide resolved
| @@ -488,7 +488,7 @@ public void run() { | |||
| ) | |||
| ) | |||
| ) { | |||
| final int registerOperations = Math.max(nodes.size(), request.getConcurrency()); | |||
| final int registerOperations = Math.max(nodes.size(), request.getRegisterOperationCount()); | |||
There was a problem hiding this comment.
This doc says the number of register operation defaults to 10. But the actual number is a max between number of nodes and number of register operations. Should we explain this nuance in the doc?
There was a problem hiding this comment.
I'm inclined to say no, because I tried describing this in the docs and it just seemed to make it harder to understand. We do more uncontended register ops too because they carry on until the contended ones finish. I'd be amazed if anyone notices this in practice.
There was a problem hiding this comment.
Eh how about a93f159? Added the word minimum to those docs, I think that covers everything simply enough.
Comment on lines
507
to
508
| synchronized (registerMutex) { | ||
| witness = registers.computeIfAbsent(key, ignored -> new BytesRegister()).compareAndExchange(expected, updated); |
There was a problem hiding this comment.
Does this synchronization introduce an artificial serialization of operations that means we are not really testing compareAndExchange in a concurrent fashion? Is this a problem?
There was a problem hiding this comment.
No, the correctness of this compareAndExchange (itself implemented as a synchronized method) isn't really the subject of this test. I added a comment in 2b4b3c7.
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2023/11/12/repo-analysis-configure-register-ops
branch
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Nov 13, 2023
Adds the `?register_operation_count` parameter that allows to control the number of register operations separately from the number of regular blob operations.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 14, 2023
In 8.12 users can configure the number of register operations performed by repository analysis, but this configuration is not available in earlier versions. Nonetheless, we should at least mention that repository analysis does some register operations. This commit backports the few relevant lines of the docs changes from elastic#102051 to earlier branches. Relates elastic#102050
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 14, 2023
In 8.12 users can configure the number of register operations performed by repository analysis, but this configuration is not available in earlier versions. Nonetheless, we should at least mention that repository analysis does some register operations. This commit backports the few relevant lines of the docs changes from #102051 to earlier branches. Relates #102050
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 14, 2023
In 8.12 users can configure the number of register operations performed by repository analysis, but this configuration is not available in earlier versions. Nonetheless, we should at least mention that repository analysis does some register operations. This commit backports the few relevant lines of the docs changes from elastic#102051 to earlier branches. Relates elastic#102050
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 14, 2023
In 8.12 users can configure the number of register operations performed by repository analysis, but this configuration is not available in earlier versions. Nonetheless, we should at least mention that repository analysis does some register operations. This commit backports the few relevant lines of the docs changes from elastic#102051 to earlier branches. Relates elastic#102050
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 14, 2023
In 8.12 users can configure the number of register operations performed by repository analysis, but this configuration is not available in earlier versions. Nonetheless, we should at least mention that repository analysis does some register operations. This commit backports the few relevant lines of the docs changes from elastic#102051 to earlier branches. Relates elastic#102050
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 14, 2023
In 8.12 users can configure the number of register operations performed by repository analysis, but this configuration is not available in earlier versions. Nonetheless, we should at least mention that repository analysis does some register operations. This commit backports the few relevant lines of the docs changes from #102051 to earlier branches. Relates #102050
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 14, 2023
In 8.12 users can configure the number of register operations performed by repository analysis, but this configuration is not available in earlier versions. Nonetheless, we should at least mention that repository analysis does some register operations. This commit backports the few relevant lines of the docs changes from #102051 to earlier branches. Relates #102050
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 14, 2023
In 8.12 users can configure the number of register operations performed by repository analysis, but this configuration is not available in earlier versions. Nonetheless, we should at least mention that repository analysis does some register operations. This commit backports the few relevant lines of the docs changes from #102051 to earlier branches. Relates #102050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
?register_operation_countparameter that allows to controlthe number of register operations separately from the number of regular
blob operations.