Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.11] Don't use an asserting searcher at all in MatchingDirectoryReader (#100668) #100685

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[8.11] Don't use an asserting searcher at all in MatchingDirectoryReader (#100668) #100685

merged 1 commit into from
Oct 11, 2023

Conversation

romseygeek
Copy link
Contributor

Backports the following commits to 8.11:

@romseygeek
Don't use an asserting searcher at all in MatchingDirectoryReader (el…
c78c7c1 
…astic#100668)

Follow up to elastic#100527

We are not testing anything to do with searching with this searcher, and so
there is no point in using LuceneTestCase.newSearcher() which will wrap
it with all sorts of extra checks that may access the underlying reader in
ways that are not anticipated by tests.

Fixes elastic#100460
Fixes elastic#99024
@romseygeek romseygeek added :Search/Search Search-related issues that do not fall into other categories >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Meta label for search team labels Oct 11, 2023
@elasticsearchmachine elasticsearchmachine mentioned this pull request Oct 11, 2023
Merged
@elasticsearchmachine elasticsearchmachine merged commit b144c7a into elastic:8.11 Oct 11, 2023
@romseygeek romseygeek deleted the backport/8.11/pr-100668 branch October 11, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romseygeek @elasticsearchmachine