-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce includeShardsStats in the stats request to indicate that we only fetch a summary #100466
Merged
elasticsearchmachine
merged 17 commits into
elastic:main
from
NEUpanning:introduce_needShardsStats
Oct 13, 2023
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0d5aecf
introduce needShardsStats in the stats request to only fetch a summary
NEUpanning 093e361
add a changelog
NEUpanning c31ecc7
set needShardsStats to true
NEUpanning 373cc6f
Naming nit
NEUpanning e3e2624
prune statsByShard in NodeIndicesStats()
NEUpanning 5f445cd
Update server/src/main/java/org/elasticsearch/rest/action/admin/clust…
NEUpanning 9f9a757
Update server/src/main/java/org/elasticsearch/indices/NodeIndicesStat…
NEUpanning c2d699c
Update x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack…
NEUpanning 431cf3d
Update x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/…
NEUpanning 100f568
Update server/src/test/java/org/elasticsearch/indices/NodeIndicesStat…
NEUpanning 8543023
add a test
NEUpanning d88d7ef
Merge branch 'main' into introduce_needShardsStats
NEUpanning d11faa4
Merge branch 'main' into introduce_needShardsStats
NEUpanning e77db60
Update server/src/main/java/org/elasticsearch/rest/action/admin/clust…
NEUpanning 9d20eda
naming TransportVersions.NEED_SHARDS_STATS_ADDED -> TransportVersions…
NEUpanning 3ddf821
test IncludeShardsStatsFlag via getShardStats(Index index) instead ge…
NEUpanning 0d35f2d
set includeShardsStats to true in DataTiersUsageTransportActionTests.…
NEUpanning File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
introduce needShardsStats in the stats request to only fetch a summary
- Loading branch information
commit 0d5aecf55764e083cb48d03d6dabc7e845e740f1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -465,6 +465,7 @@ private DiskUsage getDiskUsage() { | |
false, | ||
false, | ||
false, | ||
false, | ||
true, | ||
false, | ||
false, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2460,6 +2460,7 @@ public void ensureEstimatedStats() { | |
false, | ||
false, | ||
false, | ||
false, | ||
false | ||
); | ||
assertThat( | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming nit/suggestion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. Fixed in 373cc6f